]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
modalDialog: Remove `onPrimary` parameter
authorFlorian Müllner <fmuellner@gnome.org>
Fri, 16 Feb 2024 23:20:46 +0000 (00:20 +0100)
committerMarge Bot <marge-bot@gnome.org>
Sat, 17 Feb 2024 10:42:46 +0000 (10:42 +0000)
It was added in commit 48fb16b570 for the lock screen, but that
hasn't been based on ModalDialog for a long time.

It doesn't appear that anything else ever used the parameter,
so just remove it.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3195>

js/ui/modalDialog.js

index 3593d2565a35082c076d3e786838b7ad6ed14b9c..cab7f85c0ad12648ecf93516c9d0c1c149053e7b 100644 (file)
@@ -141,11 +141,8 @@ export const ModalDialog = GObject.registerClass({
         return this.dialogLayout.addButton(buttonInfo);
     }
 
-    _fadeOpen(onPrimary) {
-        if (onPrimary)
-            this._monitorConstraint.primary = true;
-        else
-            this._monitorConstraint.index = global.display.get_current_monitor();
+    _fadeOpen() {
+        this._monitorConstraint.index = global.display.get_current_monitor();
 
         this._setState(State.OPENING);
 
@@ -174,14 +171,14 @@ export const ModalDialog = GObject.registerClass({
             () => (this._initialKeyFocus = null), this);
     }
 
-    open(timestamp, onPrimary) {
+    open(_timestamp) {
         if (this.state === State.OPENED || this.state === State.OPENING)
             return true;
 
         if (!this.pushModal())
             return false;
 
-        this._fadeOpen(onPrimary);
+        this._fadeOpen();
         return true;
     }